From ae1ed57b3dfe003fdcb97f49e76d20a32de3f1fb Mon Sep 17 00:00:00 2001 From: Sandro Covo Date: Sat, 23 Mar 2024 20:22:48 +0100 Subject: [PATCH 1/4] Implement the correct method (upgrade/upgrade_protocol) --- http_server/_server_connection.pony | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/http_server/_server_connection.pony b/http_server/_server_connection.pony index af2f0ee..01af136 100644 --- a/http_server/_server_connection.pony +++ b/http_server/_server_connection.pony @@ -291,6 +291,6 @@ actor _ServerConnection is (Session & HTTP11RequestHandler) dispose() end - be upgrade(notify: TCPConnectionNotify iso) => + be upgrade_protocol(notify: TCPConnectionNotify iso) => _conn.set_notify(consume notify) From d379d5db5ea04e83e59d890f51487ca5b34964d6 Mon Sep 17 00:00:00 2001 From: Sandro Covo Date: Thu, 28 Mar 2024 09:57:01 +0100 Subject: [PATCH 2/4] Add release notes --- .release-notes/78.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .release-notes/78.md diff --git a/.release-notes/78.md b/.release-notes/78.md new file mode 100644 index 0000000..75c2753 --- /dev/null +++ b/.release-notes/78.md @@ -0,0 +1,7 @@ +## Rename upgrade to upgrade_protocol + +To allow changing the tcp handler of a running http connection, `Session` specifies a method `upgrade_protocol`, +which should be implemented by the concrete classes. The implementation used by the actual http server had an +implementation for this feature, but the method was called `upgrade`. As `Session` provides a default implementation +for `upgrade_protocol`, this wasn't caught. By renaming the implementation it's now possibe to use the new +feature to change the handler to a custom handler to handle for example websocket connections. From 9b9b9a1694e8636ea9c1cc85b5113ac651a8adc2 Mon Sep 17 00:00:00 2001 From: Sean T Allen Date: Tue, 2 Apr 2024 14:04:54 -0400 Subject: [PATCH 3/4] Update .release-notes/78.md --- .release-notes/78.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.release-notes/78.md b/.release-notes/78.md index 75c2753..368aad9 100644 --- a/.release-notes/78.md +++ b/.release-notes/78.md @@ -1,7 +1,3 @@ ## Rename upgrade to upgrade_protocol -To allow changing the tcp handler of a running http connection, `Session` specifies a method `upgrade_protocol`, -which should be implemented by the concrete classes. The implementation used by the actual http server had an -implementation for this feature, but the method was called `upgrade`. As `Session` provides a default implementation -for `upgrade_protocol`, this wasn't caught. By renaming the implementation it's now possibe to use the new -feature to change the handler to a custom handler to handle for example websocket connections. +To allow changing the TCP handler of a running http connection, `Session` specifies a method `upgrade_protocol`, which should be implemented by the concrete classes. The implementation used by the actual http server had an implementation for this feature, but the method was called `upgrade`. As `Session` provides a default implementation for `upgrade_protocol`, this wasn't caught. By renaming the implementation it's now possible to use the new feature to change the handler to a custom handler to handle for example WebSocket connections. From 22b6340834d83d7279b5d605586444f49cd43120 Mon Sep 17 00:00:00 2001 From: Sean T Allen Date: Tue, 2 Apr 2024 14:05:28 -0400 Subject: [PATCH 4/4] Update .release-notes/78.md --- .release-notes/78.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.release-notes/78.md b/.release-notes/78.md index 368aad9..93dbbd6 100644 --- a/.release-notes/78.md +++ b/.release-notes/78.md @@ -1,3 +1,3 @@ ## Rename upgrade to upgrade_protocol -To allow changing the TCP handler of a running http connection, `Session` specifies a method `upgrade_protocol`, which should be implemented by the concrete classes. The implementation used by the actual http server had an implementation for this feature, but the method was called `upgrade`. As `Session` provides a default implementation for `upgrade_protocol`, this wasn't caught. By renaming the implementation it's now possible to use the new feature to change the handler to a custom handler to handle for example WebSocket connections. +To allow changing the TCP handler of a running HTTP connection, `Session` specifies a method `upgrade_protocol`, which should be implemented by the concrete classes. The implementation used by the actual HTTP server had an implementation for this feature, but the method was called `upgrade`. As `Session` provides a default implementation for `upgrade_protocol`, this wasn't caught. By renaming the implementation it's now possible to use the new feature to change the handler to a custom handler to handle for example WebSocket connections.