Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove formal dependency on dreamRs/colorscale? #65

Open
joethorley opened this issue Dec 11, 2024 · 2 comments
Open

Remove formal dependency on dreamRs/colorscale? #65

joethorley opened this issue Dec 11, 2024 · 2 comments

Comments

@joethorley
Copy link
Member

No description provided.

@evanamiesgalonski
Copy link
Member

yup ill see if feasible

@evanamiesgalonski
Copy link
Member

dreamRs/colorscale uses R6 methods so its pretty hard to see the internals and reproduce something similar. The reason we import that package is cos it does an amazing job of interpolating colour by adjusting both the hue and brightness together so the resulting gradients make it way easier to distinguish differences in plots.

I'd be keen to look around for some other approaches/dive further into their code but only if you are ok with me spending a fair bit of internal time on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants