From b74e829c441b5c2975b0628b2429c45acfd1116e Mon Sep 17 00:00:00 2001 From: Nicole Hill Date: Tue, 7 Jan 2025 08:11:38 -0800 Subject: [PATCH 1/3] Update word list --- inst/WORDLIST | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/inst/WORDLIST b/inst/WORDLIST index 83bea269..24e6b9e0 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -22,10 +22,14 @@ funder hms ie lik +memoization +memoize modelling numericise +poissontemplate skewnorm summarise surprisal testthat th +vectorized From cdd5d9bcff7e83b901abe2e1064c9ed6e60cce0d Mon Sep 17 00:00:00 2001 From: Nicole Hill Date: Tue, 7 Jan 2025 08:40:27 -0800 Subject: [PATCH 2/3] Update revdep results and cran comments --- cran-comments.md | 6 +----- revdep/README.md | 33 +++++++++++++++++---------------- revdep/cran.md | 2 +- 3 files changed, 19 insertions(+), 22 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 6da2fee7..420c55d7 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,14 +1,10 @@ ## R CMD check results 0 errors | 0 warnings | 0 notes - -## CRAN Issues - -After feedback, corrected the noSuggests issue to have all tests, examples, and vignettes run conditionally for packages listed under Suggests. ## revdepcheck results -We checked 4 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. +We checked 9 reverse dependencies (0 from CRAN + 9 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. * We saw 0 new problems * We failed to check 0 packages diff --git a/revdep/README.md b/revdep/README.md index 37ddea66..bd65e733 100644 --- a/revdep/README.md +++ b/revdep/README.md @@ -1,24 +1,25 @@ # Platform -|field |value | -|:--------|:----------------------------------------| -|version |R version 4.4.1 (2024-06-14) | -|os |macOS Sonoma 14.5 | -|system |aarch64, darwin20 | -|ui |RStudio | -|language |(EN) | -|collate |en_US.UTF-8 | -|ctype |en_US.UTF-8 | -|tz |America/Vancouver | -|date |2024-08-01 | -|rstudio |2024.04.2+764 Chocolate Cosmos (desktop) | -|pandoc |NA | +|field |value | +|:--------|:------------------------------------------------------------------------------------------------| +|version |R version 4.4.2 (2024-10-31) | +|os |macOS Sequoia 15.1 | +|system |aarch64, darwin20 | +|ui |RStudio | +|language |(EN) | +|collate |en_US.UTF-8 | +|ctype |en_US.UTF-8 | +|tz |America/Vancouver | +|date |2025-01-07 | +|rstudio |2024.12.0+467 Kousa Dogwood (desktop) | +|pandoc |3.2 @ /Applications/RStudio.app/Contents/Resources/app/quarto/bin/tools/aarch64/ (via rmarkdown) | # Dependencies -|package |old |new |Δ | -|:-------|:-----|:-----|:--| -|extras |0.6.1 |0.7.1 |* | +|package |old |new |Δ | +|:-------|:----------|:----------|:--| +|extras |0.7.3.9002 |0.8.0 |* | +|chk |NA |0.9.2.9004 |* | # Revdeps diff --git a/revdep/cran.md b/revdep/cran.md index ab1853ce..1384cc8d 100644 --- a/revdep/cran.md +++ b/revdep/cran.md @@ -1,6 +1,6 @@ ## revdepcheck results -We checked 4 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. +We checked 9 reverse dependencies (0 from CRAN + 9 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. * We saw 0 new problems * We failed to check 0 packages From ba12eea89675bba3bb4f62ad40c74d768885d331 Mon Sep 17 00:00:00 2001 From: Nicole Hill Date: Tue, 7 Jan 2025 08:42:09 -0800 Subject: [PATCH 3/3] - Skip tests that use memoize if not installed --- tests/testthat/test-log-lik.R | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/testthat/test-log-lik.R b/tests/testthat/test-log-lik.R index 70de5b18..ad4ab2a5 100644 --- a/tests/testthat/test-log-lik.R +++ b/tests/testthat/test-log-lik.R @@ -172,6 +172,7 @@ test_that("beta_binom known values", { }) test_that("beta binomial deviance function is memoized", { + skip_if_not_installed("memoise") expect_true(memoise::is.memoized(lgamma_size_x)) }) @@ -197,6 +198,7 @@ test_that("lgamma_size_x produces expected outputs", { }) test_that("beta_binom memoized function gives same outputs as non-memoized function", { + skip_if_not_installed("memoise") expect_equal( log_lik_beta_binom(1:100, 200, 0.5, 0.1, memoize = FALSE), log_lik_beta_binom(1:100, 200, 0.5, 0.1, memoize = TRUE)