Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline jmbr, smbr, tmbr #66

Open
3 tasks
krlmlr opened this issue Oct 1, 2023 · 0 comments
Open
3 tasks

Inline jmbr, smbr, tmbr #66

krlmlr opened this issue Oct 1, 2023 · 0 comments

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Oct 1, 2023

We agreed on inlining the three packages that now implement embr methods:

  • jmbr
  • smbr
  • tmbr

I already did this for pmbr: 95d9cea .

Example for jmbr, substitute with smbr/tmbr as needed:

  • In jmbr, rename R/*.R to R/jmbr-*.R and tests/testthat/test-*.R to tests/testthat/test-jmbr-*.R
  • Copy over files to embr
  • Add jmbr's strong dependencies as suggested dependencies here
  • Make sure R CMD check succeeds
  • Commit
  • Implement a function that installs all of jmbr's strong dependencies with pak, using, e.g., "rjags?source" to install from source
  • In jmbr, remove all methods (so that the NAMESPACE file becomes empty)
  • Remove jmbr from poispkgs
  • Archive https://github.com/poissonconsulting/jmbr/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant