Improve perception performance #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Jan 19, 2024
| struct FeatureView: View { | ||
| let model = Model() | ||
| var body: some View { | ||
| Text(self.model.count.description) | ||
| Text(expectRuntimeWarning { self.model.count }.description) |
There was a problem hiding this comment.
Updated tests so that we can be very specific about exactly where the runtime warning is triggered. Before we were only testing that a warning was triggered somewhere or not at all.
stephencelis
approved these changes
Jan 19, 2024
|
@mbrandonw Can you tell me how to use that warning message to debug my perception? I just print the file and line with the warning message and it gave me "PerceptionRegister.swift", 124 to me where your method is in. |
|
Hi @SongJiyeon, I'm not sure I understand the question. Can you start a discussion and provide more details? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now cache the result of perception checking by the file/line where the registrar's
accessis called, but we only cache if it'strueso that we do not need to check again if a warning has already been displayed. We do not cache if it'sfalseso that we can check again next time, just in case the access is happening from a different view.