Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods 3.2.8.2 #7396

Merged
merged 2 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ Found a bug? Have a great feature idea? Get on GitHub and tell us about it and w

Our GitHub has the full list of all prior releases of Pods: https://github.com/pods-framework/pods/releases

= 3.2.8.2 - February 7th, 2025 =

* Security: Do not allow using custom SQL clauses for Relationship fields when SQL clauses are disabled in the Pods security settings. Props to the CleanTalk / Dmitrii Ignatyev for responsibly reporting this. (@sc0ttkclark)

= 3.2.8.1 - November 22nd, 2024 =

* Security: Resolve stored XSS issue with the File Upload field Add Button Text option. Props to the CleanTalk / Dmitrii Ignatyev for responsibly reporting this (their second report, they are doing good work!). (@sc0ttkclark)
Expand Down
15 changes: 14 additions & 1 deletion classes/fields/pick.php
Original file line number Diff line number Diff line change
Expand Up @@ -2696,14 +2696,23 @@ public function get_object_data( $object_params = null ) {
$params = array(
'select' => "`t`.`{$search_data->field_id}`, `t`.`{$search_data->field_index}`",
'table' => $search_data->table,
'where' => pods_v( static::$type . '_where', $options, (array) $table_info['where_default'], true ),
'where' => pods_v( static::$type . '_where', $options, null, true ),
'orderby' => pods_v( static::$type . '_orderby', $options, null, true ),
'having' => pods_v( static::$type . '_having', $options, null, true ),
'groupby' => pods_v( static::$type . '_groupby', $options, null, true ),
'pagination' => false,
'search' => false,
);

if ( ! pods_can_use_dynamic_feature_sql_clauses() ) {
$params['where'] = $params['where'] ? '0=1 /* Dynamic SQL clauses disabled in Pods */' : (array) $table_info['where_default'];
$params['orderby'] = null;
$params['having'] = null;
$params['groupby'] = null;
} elseif ( null === $params['where'] ) {
$params['where'] = (array) $table_info['where_default'];
}

if ( in_array( $options[ static::$type . '_object' ], array( 'site', 'network' ), true ) ) {
$params['select'] .= ', `t`.`path`';
}
Expand Down Expand Up @@ -2883,6 +2892,10 @@ public function get_object_data( $object_params = null ) {

$pick_orderby = pods_v( static::$type . '_orderby', $options, null, true );

if ( ! pods_can_use_dynamic_feature_sql_clauses() ) {
$pick_orderby = null;
}

if ( is_string( $pick_orderby ) && 0 < strlen( $pick_orderby ) ) {
$orderby[] = $pick_orderby;
}
Expand Down
5 changes: 5 additions & 0 deletions classes/widgets/PodsWidgetList.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
'cache_mode' => trim( (string) pods_v( 'cache_mode', $instance, 'none', true ) ),
);

if ( ! pods_can_use_dynamic_feature_sql_clauses() ) {
$args['orderby'] = '';
$args['where'] = $args['where'] ? '0=1 /* Dynamic SQL clauses disabled in Pods */' : '';
}

$content = trim( (string) pods_v( 'template_custom', $instance, '' ) );

if ( 0 < strlen( $args['name'] ) && ( 0 < strlen( $args['template'] ) || 0 < strlen( $content ) ) ) {
Expand Down Expand Up @@ -87,6 +92,6 @@
$before_content = pods_v( 'before_content', $instance, '' );
$after_content = pods_v( 'after_content', $instance, '' );

require PODS_DIR . 'ui/admin/widgets/list.php';

Check failure on line 95 in classes/widgets/PodsWidgetList.php

View workflow job for this annotation

GitHub Actions / phpstan / phpstan (7.4)

Method PodsWidgetList::form() should return string but return statement is missing.

Check failure on line 95 in classes/widgets/PodsWidgetList.php

View workflow job for this annotation

GitHub Actions / phpstan / phpstan (8.0)

Method PodsWidgetList::form() should return string but return statement is missing.

Check failure on line 95 in classes/widgets/PodsWidgetList.php

View workflow job for this annotation

GitHub Actions / phpstan / phpstan (8.1)

Method PodsWidgetList::form() should return string but return statement is missing.

Check failure on line 95 in classes/widgets/PodsWidgetList.php

View workflow job for this annotation

GitHub Actions / phpstan / phpstan (8.2)

Method PodsWidgetList::form() should return string but return statement is missing.

Check failure on line 95 in classes/widgets/PodsWidgetList.php

View workflow job for this annotation

GitHub Actions / phpstan / phpstan (8.3)

Method PodsWidgetList::form() should return string but return statement is missing.
}
}
4 changes: 2 additions & 2 deletions init.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Plugin Name: Pods - Custom Content Types and Fields
* Plugin URI: https://pods.io/
* Description: Pods is a framework for creating, managing, and deploying customized content types and fields
* Version: 3.2.8.1
* Version: 3.2.8.2
* Author: Pods Framework Team
* Author URI: https://pods.io/about/
* Text Domain: pods
Expand Down Expand Up @@ -43,7 +43,7 @@
add_action( 'init', 'pods_deactivate_pods_ui' );
} else {
// Current version.
define( 'PODS_VERSION', '3.2.8.1' );
define( 'PODS_VERSION', '3.2.8.2' );

// Current database version, this is the last version the database changed.
define( 'PODS_DB_VERSION', '2.3.5' );
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pods",
"version": "3.2.8.1",
"version": "3.2.8.2",
"description": "Pods is a development framework for creating, extending, managing, and deploying customized content types in WordPress.",
"author": "Pods Foundation, Inc",
"homepage": "https://pods.io/",
Expand Down
6 changes: 5 additions & 1 deletion readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Tags: pods, custom post types, custom taxonomies, content types, custom fields
Requires at least: 6.0
Tested up to: 6.7
Requires PHP: 7.2
Stable tag: 3.2.8.1
Stable tag: 3.2.8.2
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -182,6 +182,10 @@ Pods really wouldn't be where it is without all the contributions from our [dono

== Changelog ==

= 3.2.8.2 - February 7th, 2025 =

* Security: Do not allow using custom SQL clauses for Relationship fields when SQL clauses are disabled in the Pods security settings. Props to the CleanTalk / Dmitrii Ignatyev for responsibly reporting this. (@sc0ttkclark)

= 3.2.8.1 - November 22nd, 2024 =

* Security: Resolve stored XSS issue with the File Upload field Add Button Text option. Props to the CleanTalk / Dmitrii Ignatyev for responsibly reporting this (their second report, they are doing good work!). (@sc0ttkclark)
Expand Down
Loading