Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText: Add https:// as placeholder instead of textbox value when adding url #1651

Closed
daenur76 opened this issue Sep 21, 2023 · 5 comments · Fixed by #1709
Closed

RichText: Add https:// as placeholder instead of textbox value when adding url #1651

daenur76 opened this issue Sep 21, 2023 · 5 comments · Fixed by #1709
Assignees
@daenur76
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone
3.16.0

Comments

@daenur76
Copy link

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

[ 3.15.0 ]

Expected / Desired Behavior / Question

When you are adding a url to the text in the RichText control, the url text box should have a place holder text saying "https://". Today, the url text box instead have a default value of "https://", giving that when you paste a url into the box, the value becomes "https://https://...". This is very annoying and can be defined as an incorrect behaviour for editors.
@ghost
Copy link

ghost commented Sep 21, 2023

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Sep 21, 2023
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@michaelmaillot michaelmaillot added help wanted Good First Issue 🏆 type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Sep 25, 2023
@michaelmaillot
Copy link
Collaborator

Hi @daenur76,

You're right, this should be displayed as a placeholder instead of a value.

Are you insterested to submit a PR for this one?

daenur76 pushed a commit to daenur76/sp-dev-fx-controls-react that referenced this issue Sep 26, 2023
@JoakimIntra
Issue pnp#1651. Added placeholder for RichText urls.
e0a1690
daenur76 pushed a commit to daenur76/sp-dev-fx-controls-react that referenced this issue Sep 26, 2023
@JoakimIntra
Issue pnp#1651. Added placeholder for RichText urls.
b06eab6
@daenur76 daenur76 mentioned this issue Sep 26, 2023
Merged
@daenur76
Copy link
Author

@michaelmaillot Of course, PR has been submitted.

@michaelmaillot michaelmaillot added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed help wanted Good First Issue 🏆 labels Sep 26, 2023
michaelmaillot added a commit that referenced this issue Oct 5, 2023
@michaelmaillot
Merge pull request #1656 from daenur76/issue-1651
5dc135b 
Issue #1651. Added placeholder for RichText urls.
@michaelmaillot michaelmaillot added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Oct 5, 2023
@michaelmaillot michaelmaillot added this to the 3.16.0 milestone Oct 5, 2023
@michaelmaillot
Copy link
Collaborator

Linked PR has been merged and should be available soon in the beta release.

@AJIXuMuK AJIXuMuK mentioned this issue Nov 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daenur76 daenur76

Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Milestone
3.16.0
Development

Successfully merging a pull request may close this issue.

3.16.0 pnp/sp-dev-fx-controls-react
2 participants
@daenur76 @michaelmaillot