From 2796b0d5019429526a38e6a92fcb03e239d03baa Mon Sep 17 00:00:00 2001 From: Tobias Nyholm Date: Mon, 30 Dec 2019 17:29:20 +0100 Subject: [PATCH] Some small bugfixes and updated readme (#7) * Small bugfixes and cleanup * Updated readme with new extensions * cs * Typo --- Makefile | 2 ++ Readme.md | 5 +++++ src/Aws/LayerProvider.php | 8 +++++--- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index e45a5a0a..0224db40 100644 --- a/Makefile +++ b/Makefile @@ -4,6 +4,7 @@ php_versions = 72 73 74 docker-images: PWD=pwd + set -e; \ for dir in layers/*; do \ for php_version in $(php_versions); do \ echo "###############################################"; \ @@ -21,6 +22,7 @@ layers: docker-images PWD=pwd rm -rf export/layer-*.zip || true mkdir export/tmp + set -e; \ for dir in layers/*; do \ for php_version in $(php_versions); do \ echo "###############################################"; \ diff --git a/Readme.md b/Readme.md index 206d04c3..80af3db1 100644 --- a/Readme.md +++ b/Readme.md @@ -39,8 +39,13 @@ extension=/opt/bref-extra/amqp.so | ---- | ----------------------------| -------------- | | AMQP | `${bref:extra.amqp-php-74}` | `extension=/opt/bref-extra/amqp.so` | | Blackfire | `${bref:extra.blackfire-php-74}` | `extension=/opt/bref-extra/blackfire.so` | +| GMP | `${bref:extra.gmp-php-74}` | `extension=/opt/bref-extra/gmp.so` | +| Memcache | `${bref:extra.memcached-php-74}` | `extension=/opt/bref-extra/memcache.so` | +| Memcached | `${bref:extra.memcached-php-74}` | `extension=/opt/bref-extra/memcached.so` | | Xdebug | `${bref:extra.xdebug-php-74}` | `zend_extension=/opt/bref-extra/xdebug.so` | +Note that the "Memcached" layer provides both extension for [Memcache](https://pecl.php.net/package/memcache) and [Memcached](https://pecl.php.net/package/memcached). + ## Deploy new versions ``` diff --git a/src/Aws/LayerProvider.php b/src/Aws/LayerProvider.php index 8d88c2eb..a9c40253 100644 --- a/src/Aws/LayerProvider.php +++ b/src/Aws/LayerProvider.php @@ -3,6 +3,7 @@ namespace Bref\Extra\Aws; use Aws\Lambda\LambdaClient; +use function GuzzleHttp\Promise\unwrap; /** * Fetches layers and details from AWS @@ -25,7 +26,6 @@ public function __construct(array $layerNames, string $awsId) $this->layerNames = $layerNames; } - public function listLayers(string $selectedRegion): array { $lambda = new LambdaClient([ @@ -49,8 +49,10 @@ public function listLayers(string $selectedRegion): array $layers = []; foreach ($results as $layerName => $result) { $versions = $result['LayerVersions']; - $latestVersion = end($versions); - $layers[$layerName] = $latestVersion['Version']; + if (! empty($versions)) { + $latestVersion = end($versions); + $layers[$layerName] = $latestVersion['Version']; + } } return $layers;