Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jsx-lexer #347

Closed
stevepiercy opened this issue Oct 31, 2018 · 5 comments
Closed

Add support for jsx-lexer #347

stevepiercy opened this issue Oct 31, 2018 · 5 comments

Comments

@stevepiercy
Copy link
Contributor

stevepiercy commented Oct 31, 2018

We've got at least three trainings that could use jsx as a lexer via jsx-lexer. This lexer works with other themes, but not the RTD theme.

See #341 (comment)

I have no idea whether it is possible to customize the RTD theme for lexers not included with Pygments.

Filed ticket upstream on 2024-11-07 in pygments/pygments#2816.

@sneridagh
Copy link
Member

+1 also we need to add a less lexer too!

@svx do you think it's possible?

@stevepiercy
Copy link
Contributor Author

I just ran a test, and it appears that both the default and RTD themes lack sufficient styling to make jsx-lexer useful. But there is an open PR upstream in Pygments

@stevepiercy
Copy link
Contributor Author

We now have a JSX, LESS, and SCSS lexers with the new theme. However, the JSX is not that great. We might need to use JS or plain old text.

@stevepiercy
Copy link
Contributor Author

When writing JSX code, avoid using ' in HTML tags. The lexer barfs on it.

@stevepiercy
Copy link
Contributor Author

See fcurella/jsx-lexer#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants