From f7da31740c4b51b1e5daba6ca3487552b40eca9e Mon Sep 17 00:00:00 2001 From: Ricky O'Steen Date: Wed, 30 Dec 2020 11:35:16 -0500 Subject: [PATCH 1/2] Change from raising error to snackbar error message --- jdaviz/app.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/jdaviz/app.py b/jdaviz/app.py index 4a5a8f8e9c..f40e14f836 100644 --- a/jdaviz/app.py +++ b/jdaviz/app.py @@ -272,7 +272,11 @@ def load_data(self, file_obj, parser_reference=None, **kwargs): # Properly form path and check if a valid file file_obj = pathlib.Path(file_obj) if not file_obj.exists(): - raise FileNotFoundError("Could not locate file: " + file_obj) + msg_text = "Error: File {} does not exist".format(file_obj) + snackbar_message = SnackbarMessage(msg_text, sender=self, + color='error') + self.hub.broadcast(snackbar_message) + return else: # Convert path to properly formatted string (Parsers do not accept path objs) file_obj = str(file_obj) From 815bf0fc692706ddefba10102a1cf15873870016 Mon Sep 17 00:00:00 2001 From: Ricky O'Steen Date: Tue, 19 Jan 2021 09:30:54 -0500 Subject: [PATCH 2/2] Add fixed exception back in --- jdaviz/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jdaviz/app.py b/jdaviz/app.py index f40e14f836..dd4cc4eb7a 100644 --- a/jdaviz/app.py +++ b/jdaviz/app.py @@ -276,7 +276,7 @@ def load_data(self, file_obj, parser_reference=None, **kwargs): snackbar_message = SnackbarMessage(msg_text, sender=self, color='error') self.hub.broadcast(snackbar_message) - return + raise FileNotFoundError("Could not locate file: {}".format(file_obj)) else: # Convert path to properly formatted string (Parsers do not accept path objs) file_obj = str(file_obj)