-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: sort replies by new, old, and default with top #468
Labels
enhancement
New feature or request
Comments
we already have the code for sort by best if you want to add it https://github.com/plebbit/plebbit-react-hooks/blob/77aa5d00542414af0b13afe1e642960b0848aff5/src/stores/feeds/feed-sorter.ts#L98 we probably wont have top sort in replies because of plebbit/plebbit-js#44 (comment) the reply sorts will probably only be
|
changed "top" to "best", using that algo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
They are already sorted by top, but it says "best". It should say "top", and also allow to sort by new or old. We can add the other sort types later, once they get added to the API.
The text was updated successfully, but these errors were encountered: