Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some links are embedded as videos but they are webpages or images #385

Closed
plebeius-eth opened this issue Oct 11, 2024 · 3 comments
Closed

fix: some links are embedded as videos but they are webpages or images #385

plebeius-eth opened this issue Oct 11, 2024 · 3 comments
Assignees
@plebeius-eth
Labels
bug Something isn't working

Comments

@plebeius-eth
Copy link
Member

looks like ext-name is bugged

cryptoserious.eth/c/QmVFbPMmPQAobLLUvrpLPFtcLMQTQZJGM6JwdgQym13fKu
@plebeius-eth plebeius-eth self-assigned this Oct 11, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Oct 11, 2024
@plebeius-eth plebeius-eth added the bug Something isn't working label Oct 11, 2024
@plebeius-eth plebeius-eth mentioned this issue Oct 11, 2024
Closed
plebeius-eth added a commit to plebbit/plebchan that referenced this issue Oct 11, 2024
@plebeius-eth
fix(post): some links to images could be embedded as videos
46e1189 
same as plebbit/seedit#385
@plebeius-eth
Copy link
Member Author

18b5a8e

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Oct 12, 2024
@estebanabaroa
Copy link
Member

estebanabaroa commented Oct 16, 2024 •
edited
Loading

doing new URL() isn't free, it wastes ms, which makes the feed lag when you scroll, you shouldnt do it over and over. you should do it the minimum amount of times per post possible, ideally only once

in this function you're doing it twice for no reason

@estebanabaroa estebanabaroa reopened this Oct 16, 2024
@plebeius-eth
Copy link
Member Author

fixed 4103731

@plebeius-eth plebeius-eth removed this from seedit Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plebeius-eth plebeius-eth

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@estebanabaroa @plebeius-eth