Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spoiler option to submit page #191

Closed
plebeius-eth opened this issue Jan 21, 2024 · 5 comments
Closed

add spoiler option to submit page #191

plebeius-eth opened this issue Jan 21, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@plebeius-eth
Copy link
Member

I think the user should be able to post something marking it as spoiler right away. Some kind of "mark as NSFW" button can also be added later.

@plebeius-eth plebeius-eth self-assigned this Jan 21, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Jan 21, 2024
@plebeius-eth plebeius-eth added the enhancement New feature or request label Jan 21, 2024
@plebeius-eth plebeius-eth moved this from Todo to Done in seedit Apr 29, 2024
@plebeius-eth
Copy link
Member Author

e4a50fe

@estebanabaroa
Copy link
Member

why is it "mark as spoiler", seems redundant, it should just be [ ] spoiler

here's how they do it on new reddit
image

@estebanabaroa estebanabaroa reopened this Jun 1, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit Jun 1, 2024
@plebeius-eth plebeius-eth removed the status in seedit Jun 1, 2024
@plebeius-eth
Copy link
Member Author

I agree it was redundant, fixed 1b88937

@estebanabaroa
Copy link
Member

I think the spoiler should probably only apply to the media, not the text. I wrote about why here plebbit/plebchan#368 (comment)

@estebanabaroa estebanabaroa reopened this Jun 9, 2024
@estebanabaroa estebanabaroa moved this from Done to Todo in seedit Jun 9, 2024
@plebeius-eth plebeius-eth removed the status in seedit Jun 10, 2024
@plebeius-eth
Copy link
Member Author

This issue was completed, it's only about making a comment as spoiler (comment.spoiler) which adds the SPOILER label to the comment, and blurs media if any.

Image

@github-project-automation github-project-automation bot moved this to Done in seedit Jan 8, 2025
@plebeius-eth plebeius-eth removed this from seedit Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants