Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changing account bugs the API, user can delete the last account #178

Closed
plebeius-eth opened this issue Jan 12, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@plebeius-eth
Copy link
Member

Changing an account should trigger a refresh, otherwise the API bugs out. The user shouldn't be able to delete the last account, otherwise he won't be able to create a new one (account id gets lost)

@plebeius-eth plebeius-eth self-assigned this Jan 12, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Jan 12, 2024
@plebeius-eth plebeius-eth added the bug Something isn't working label Jan 12, 2024
@plebeius-eth plebeius-eth moved this from Todo to In Progress in seedit Jan 12, 2024
@plebeius-eth
Copy link
Member Author

14fde38

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Jan 12, 2024
@estebanabaroa
Copy link
Member

estebanabaroa commented Feb 10, 2024

you shouldnt reload when changing accounts that's really bad UX, if it's a hooks bug it needs to be fixed in the hooks

also the hooks allow deleting the last account, it works on plebones, though you can't access the create button, but when you reload it creates a new account automatically when there are none

@estebanabaroa estebanabaroa reopened this Feb 10, 2024
@plebeius-eth
Copy link
Member Author

updated 51f7dba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants