Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changing the sort type shouldn't change the time filter #172

Closed
plebeius-eth opened this issue Jan 7, 2024 · 3 comments
Closed

fix changing the sort type shouldn't change the time filter #172

plebeius-eth opened this issue Jan 7, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@plebeius-eth
Copy link
Member

plebeius-eth commented Jan 7, 2024

for example when you click HOME or ALL, or change the sort type, or change the filter type, it should keep the same sort type and filter you're already on
there's no easy way to implement that but you can check how I did it in plebones

@plebeius-eth plebeius-eth self-assigned this Jan 7, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Jan 7, 2024
@plebeius-eth plebeius-eth added the bug Something isn't working label Jan 7, 2024
@plebeius-eth plebeius-eth moved this from Todo to In Progress in seedit Feb 7, 2024
@plebeius-eth
Copy link
Member Author

e2de559
da75c69

@github-project-automation github-project-automation bot moved this from In Progress to Done in seedit Feb 7, 2024
@estebanabaroa
Copy link
Member

can't use useEffect to setState, it causes useless rerenders and slows down the app

@estebanabaroa estebanabaroa reopened this Feb 10, 2024
@plebeius-eth
Copy link
Member Author

updated ce32277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants