Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page not found view #159

Closed
plebeius-eth opened this issue Jan 3, 2024 · 2 comments
Closed

add page not found view #159

plebeius-eth opened this issue Jan 3, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@plebeius-eth
Copy link
Member

plebeius-eth commented Jan 3, 2024

Routes are in src/app.tsx, view components are in src/views.

This issue is about making a new folder in src/views, /not-found/, containing index.ts, not-found.tsx and not-found.module.css (like all other components).

The not found page should probably look similar to the ones on old reddit, but we shouldn't use reddit's mascot at all.

If the user types any route that is not a view component, it should redirect to this not found page. I think at the center of the page there should be a link to the homepage.

@plebeius-eth plebeius-eth converted this from a draft issue Jan 3, 2024
@plebeius-eth plebeius-eth self-assigned this Jan 3, 2024
@plebeius-eth plebeius-eth added enhancement New feature or request good first issue Good for newcomers labels Jan 3, 2024
@plebeius-eth plebeius-eth removed their assignment Feb 4, 2024
@plebeius-eth plebeius-eth removed the status in seedit Feb 4, 2024
@plebeius-eth plebeius-eth moved this to Todo in seedit Feb 9, 2024
@plebeius-eth
Copy link
Member Author

user should be redirected to not found page immediately if a cid is not exactly 46 characters, not alphanumeric etc. Should also check the subplebbit address (if does contain '.' or not, etc). This is to prevent useless loading times for invalid links

@plebeius-eth plebeius-eth self-assigned this Feb 14, 2024
@plebeius-eth
Copy link
Member Author

e8ee496
f162a92
c8b48fe

@github-project-automation github-project-automation bot moved this from Todo to Done in seedit Feb 14, 2024
@plebeius-eth plebeius-eth removed this from seedit Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant