Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some links are embedded as videos but they are webpages or images #559

Closed
plebeius-eth opened this issue Oct 11, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@plebeius-eth
Copy link
Member

same as plebbit/seedit#385

@plebeius-eth plebeius-eth self-assigned this Oct 11, 2024
@plebeius-eth plebeius-eth converted this from a draft issue Oct 11, 2024
@plebeius-eth plebeius-eth added the bug Something isn't working label Oct 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in plebchan Oct 11, 2024
@plebeius-eth
Copy link
Member Author

e9280ac

@estebanabaroa
Copy link
Member

doing new URL() isn't free, it wastes ms, which makes the feed lag when you scroll, you shouldnt do it over and over. you should do it the minimum amount of times per post possible, ideally only once

in this function you're doing it twice for no reason

@estebanabaroa estebanabaroa reopened this Oct 16, 2024
@plebeius-eth
Copy link
Member Author

plebeius-eth commented Oct 17, 2024

fixed 0841405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants