From 445fb138c644f4e2f14e0e2d9dc0c2939700a5c1 Mon Sep 17 00:00:00 2001 From: brocollie08 Date: Mon, 15 Jul 2024 13:59:02 -0400 Subject: [PATCH 1/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e9702a02f..3b0b160a7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,7 +17,7 @@ If the changes are larger (API design, architecture, etc), [opening an issue](ht * [Swift >= 5.5](https://www.swift.org/download/) * [Xcode 15.3](https://developer.apple.com/download/all/) -* [Android NDK >= 19.2.5345600, <= 21](https://github.com/android/ndk/wiki/Unsupported-Downloads#r19c). Any version > 21 will not work, period. You'll need to add `ANDROID_NDK_HOME` to your environment manually. +* [Android NDK 23.2.8568313](https://github.com/android/ndk/wiki/Unsupported-Downloads#r23c). You'll need to add `ANDROID_NDK_HOME` to your environment manually. * Python < 3 (recommended 2.7.18) - you can use [pyenv](https://realpython.com/intro-to-pyenv/) to manage different python versions with ease. * [Signed Commits](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification). For convenience it is recommended to set git to sign all commits by default as mentioned [here](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key) From 430a57f0cd8373fcbbe25470c0d1ce5428f86512 Mon Sep 17 00:00:00 2001 From: brocollie08 Date: Mon, 15 Jul 2024 15:21:25 -0400 Subject: [PATCH 2/2] Update config.yml --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bca2410ba..257ba519d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -16,7 +16,7 @@ orbs: executors: base: docker: - - image: docker.io/playerui/bazel-docker:10 + - image: docker.io/playerui/bazel-docker working_directory: ~/player resource_class: xlarge environment: @@ -523,4 +523,4 @@ workflows: requires: - android_test - coverage - - build_ios \ No newline at end of file + - build_ios