From 01406ede688b14740128d676db32a60726a7511d Mon Sep 17 00:00:00 2001 From: Adam Dierkens Date: Fri, 28 Jun 2024 21:51:45 -0400 Subject: [PATCH] Remove alternate binding parsers from bundle Signed-off-by: Adam Dierkens --- core/player/BUILD | 8 ++++---- core/player/src/binding-grammar/index.ts | 4 ++-- core/player/src/binding/__tests__/resolver.test.ts | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/core/player/BUILD b/core/player/BUILD index 85e337e31..eaea40c72 100644 --- a/core/player/BUILD +++ b/core/player/BUILD @@ -9,15 +9,15 @@ javascript_pipeline( "@npm//p-defer", "@npm//queue-microtask", "@npm//tapable-ts", - "@npm//parsimmon", - "@npm//@types/parsimmon", - "@npm//arr-flatten", - "@npm//ebnf", "@npm//timm", "@npm//error-polyfill", "@npm//ts-nested-error" ], test_data = [ + "@npm//arr-flatten", + "@npm//ebnf", + "@npm//parsimmon", + "@npm//@types/parsimmon", "//core/make-flow:@player-ui/make-flow", "//plugins/common-types/core:@player-ui/common-types-plugin", ], diff --git a/core/player/src/binding-grammar/index.ts b/core/player/src/binding-grammar/index.ts index b43c569c2..1ddee3021 100644 --- a/core/player/src/binding-grammar/index.ts +++ b/core/player/src/binding-grammar/index.ts @@ -1,4 +1,4 @@ export * from './ast'; -export { parse as parseParsimmon } from './parsimmon'; -export { parse as parseEBNF } from './ebnf'; +// export { parse as parseParsimmon } from './parsimmon'; +// export { parse as parseEBNF } from './ebnf'; export { parse as parseCustom } from './custom'; diff --git a/core/player/src/binding/__tests__/resolver.test.ts b/core/player/src/binding/__tests__/resolver.test.ts index f670af356..59c439569 100644 --- a/core/player/src/binding/__tests__/resolver.test.ts +++ b/core/player/src/binding/__tests__/resolver.test.ts @@ -1,7 +1,7 @@ import get from 'dlv'; import type { ParserSuccessResult } from '../../binding-grammar'; -import { parseParsimmon } from '../../binding-grammar'; +import { parseCustom } from '../../binding-grammar'; import { resolveBindingAST } from '../resolver'; import { getBindingSegments } from '../utils'; @@ -33,7 +33,7 @@ const testCases: Array<[string, string]> = [ ]; test.each(testCases)('Resolving binding: %s', (binding, expectedResolved) => { - const parsedBinding = parseParsimmon(binding); + const parsedBinding = parseCustom(binding); expect(parsedBinding.status).toBe(true); const actual = resolveBindingAST( (parsedBinding as ParserSuccessResult).path, @@ -48,7 +48,7 @@ test.each(testCases)('Resolving binding: %s', (binding, expectedResolved) => { }); test('works for nested keys', () => { - const parsedBinding = parseParsimmon('foo.{{BASE_PATH}}.bar'); + const parsedBinding = parseCustom('foo.{{BASE_PATH}}.bar'); expect(parsedBinding.status).toBe(true); const resolved = resolveBindingAST( @@ -65,7 +65,7 @@ test('works for nested keys', () => { describe('expressions', () => { test('evaluates expressions as paths', () => { - const parsedBinding = parseParsimmon('foo.bar.`exp()`'); + const parsedBinding = parseCustom('foo.bar.`exp()`'); const evaluate = jest.fn().mockReturnValue(100); const resolved = resolveBindingAST(