Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update managed player to sync plugins and middleware #595

Closed

Conversation

spentacular
Copy link
Contributor

@spentacular spentacular commented Feb 19, 2025

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@spentacular spentacular changed the title initial updates to managed player for syncing middleware and plugins update managed player to sync plugins and middleware Feb 19, 2025
@spentacular
Copy link
Contributor Author

/canary

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 43.93939% with 37 lines in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (0359f49) to head (cf96426).

Files with missing lines Patch % Lines
react/player/src/manager/managed-player.tsx 43.93% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   89.77%   89.62%   -0.16%     
==========================================
  Files         331      331              
  Lines       19904    19963      +59     
  Branches     1949     1954       +5     
==========================================
+ Hits        17868    17891      +23     
- Misses       2022     2058      +36     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy
Copy link
Member

/canary

@spentacular spentacular added the minor Increment the minor version when merged label Feb 19, 2025
@spentacular
Copy link
Contributor Author

/canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants