Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose metrics plugin hooks android #591

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

mrigankmg
Copy link
Contributor

Change Type (required)

Expose onFlowBegin, onFlowEnd, onRenderEnd metrics plugin hooks for Android

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@mrigankmg mrigankmg force-pushed the expose-metrics-plugin-hooks-android branch 2 times, most recently from ba73e53 to 751a47e Compare February 13, 2025 20:25
@TestTemplate
fun `should trigger onRenderEnd hook`() {
var onRenderEndTapped = false
plugin?.hooks?.onRenderEnd?.tap("test") { _, _, _ ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to assert the 3 values from the handler or assert not null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think asserting on the type should be good enough, since the value assertion should be handled in core?

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (0e5ca93) to head (72fb5fd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files         331      331           
  Lines       19904    19904           
  Branches     1949     1949           
=======================================
  Hits        17868    17868           
  Misses       2022     2022           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrigankmg mrigankmg force-pushed the expose-metrics-plugin-hooks-android branch from fb65be0 to 0af3497 Compare February 19, 2025 17:36
@mrigankmg mrigankmg force-pushed the expose-metrics-plugin-hooks-android branch from 233e817 to cc00806 Compare February 20, 2025 15:07
@mrigankmg mrigankmg force-pushed the expose-metrics-plugin-hooks-android branch from cc00806 to e346976 Compare February 25, 2025 17:17
@mrigankmg mrigankmg force-pushed the expose-metrics-plugin-hooks-android branch from 4bcbf65 to 72fb5fd Compare February 25, 2025 18:43
@mrigankmg mrigankmg merged commit d2b6393 into main Feb 25, 2025
11 checks passed
@mrigankmg mrigankmg deleted the expose-metrics-plugin-hooks-android branch February 25, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants