-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose metrics plugin hooks android #591
Conversation
ba73e53
to
751a47e
Compare
@TestTemplate | ||
fun `should trigger onRenderEnd hook`() { | ||
var onRenderEndTapped = false | ||
plugin?.hooks?.onRenderEnd?.tap("test") { _, _, _ -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to assert the 3 values from the handler or assert not null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think asserting on the type should be good enough, since the value assertion should be handled in core?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 331 331
Lines 19904 19904
Branches 1949 1949
=======================================
Hits 17868 17868
Misses 2022 2022
Partials 14 14 ☔ View full report in Codecov by Sentry. |
fb65be0
to
0af3497
Compare
plugins/metrics/jvm/src/main/kotlin/com/intuit/playerui/plugins/metrics/MetricsPlugin.kt
Show resolved
Hide resolved
233e817
to
cc00806
Compare
cc00806
to
e346976
Compare
4bcbf65
to
72fb5fd
Compare
Change Type (required)
Expose onFlowBegin, onFlowEnd, onRenderEnd metrics plugin hooks for Android
patch
minor
major
N/A
Does your PR have any documentation updates?