Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Node.snapshot public #588

Closed
wants to merge 1 commit into from
Closed

Conversation

A1shK
Copy link
Contributor

@A1shK A1shK commented Feb 10, 2025

This PR marks Node.snapshot as public. Since it was already displayed marked as an experimental API, I decided not to add any docs around it as I am not sure if its intended to be advertised.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Release Notes

Making Node.Snapshot public. This utility can be used to decode a Node entirely as a snapshot of its current data.

@A1shK A1shK marked this pull request as ready for review February 10, 2025 21:29
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (83250d0) to head (aa72500).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   89.77%   89.77%   -0.01%     
==========================================
  Files         331      331              
  Lines       19904    19904              
  Branches     1949     1949              
==========================================
- Hits        17869    17868       -1     
- Misses       2021     2022       +1     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy
Copy link
Member

In my opinion if it’s going to be public there should be docs around it, even if the docs mention it’s a potential unstable API just to make sure that’s disclosed. I’ll defer to @sugarmanz or @brocollie08 though

@A1shK
Copy link
Contributor Author

A1shK commented Feb 11, 2025

Closing because I dont think we need this right now.

@A1shK A1shK closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants