Moved AssetTest and Assertions into an android testutils package #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrigankmg
requested review from
sugarmanz,
brocollie08 and
adierkens
as code owners
brocollie08
reviewed
Feb 7, 2025
android/testutils/src/main/java/com/intuit/playerui/android/testutils/asset/AssetTest.kt
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
- Coverage 89.77% 89.77% -0.01%
==========================================
Files 331 331
Lines 19904 19904
Branches 1949 1949
==========================================
- Hits 17869 17868 -1
- Misses 2021 2022 +1
Partials 14 14 ☔ View full report in Codecov by Sentry. |
mrigankmg
force-pushed
the
android-testutils
branch
from
5592d91 to
1f984b7
Compare
mrigankmg
force-pushed
the
android-testutils
branch
from
64650f1 to
1ac2534
Compare
mrigankmg
changed the title
brocollie08
reviewed
Feb 13, 2025
| deps = main_deps, | ||
| ) | ||
|
|
||
| android_library( |
There was a problem hiding this comment.
is this wrap necessary
There was a problem hiding this comment.
I think I need it for the specific maven coordinates?
brocollie08
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Moved AssetTest and Aseertions into an android testutils package
patchminormajorN/ADoes your PR have any documentation updates?