iOS: JavascriptCore Exceptions when finding classes #577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reusing a
JSContext
that had already loaded JS classes, JavascriptCore would throw exceptions when walking through the dot separated classnames as JSValue can be non-nil with an underlyingundefined
value. Adding a check forisUndefined
lets us short circuit the classname reference recursion and skip back to resource loading.Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
N/A
Does your PR have any documentation updates?
📦 Published PR as canary version:
0.10.2--canary.577.19320
Try this version out locally by upgrading relevant packages to 0.10.2--canary.577.19320