-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example asset and transform for async content streaming #575
base: main
Are you sure you want to change the base?
Conversation
/canary |
8070a39
to
964cc11
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
- Coverage 89.75% 89.72% -0.04%
==========================================
Files 331 334 +3
Lines 19840 19923 +83
Branches 1949 1956 +7
==========================================
+ Hits 17808 17875 +67
- Misses 2018 2034 +16
Partials 14 14 ☔ View full report in Codecov by Sentry. |
plugins/reference-assets/mocks/chat-message/chat-message-basic.json
Outdated
Show resolved
Hide resolved
Can we add some docs to the main site about how to author async assets? |
@KetanReddy ty for reviewing! i'm planning to have a separate pr for doc update including core, react, iOS and Android. this pr only contains change for core and react. |
What is the work remaining on the other platforms? I see there is an iOS PR open but from my understanding this should mostly be a core PR. Ideally we would merge in all those portions + docs in the same PR |
…t accept only chat-message asset instead of a list, also updated asyncNodeUpdate type to Any instead of a list to support the existing use-case
Async streaming android
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
N/A
Does your PR have any documentation updates?
Release Notes
Player streaming enhancement
chat-message
asset inReferenceAssetsPlugin
as async streaming exampleAsyncNodePlugin
to generate async asset transformInstead of adding
{async: true}
in content, replace it with a special type of asset, eg.chat-message
and write a transform function.