Only mutate ManagedPlayerViewModel.loadingState on main thread #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Published properties in SwiftUI models should not be mutated on background threads. Refactor `ManagedPlayerViewModel.next` to ensure all paths that update `loadingState` do so from the main thread. Add unit tests to verify loadingState changes arrive on the main thread when next is called.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 89.70% 94.36% +4.66%
==========================================
Files 331 145 -186
Lines 19794 9160 -10634
Branches 1949 0 -1949
==========================================
- Hits 17756 8644 -9112
+ Misses 2024 516 -1508
+ Partials 14 0 -14 ☔ View full report in Codecov by Sentry. |
nancywu1
approved these changes
Jan 3, 2025
hborawski
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Published properties in SwiftUI models should not be mutated on background threads.
Refactor
ManagedPlayerViewModel.nextto ensure all paths that updateloadingStatedo so from the main thread.Add unit tests to verify loadingState changes arrive on the main thread when next is called.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?