add unit tests for reference input transform #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bazel-6 #366 +/- ##
===========================================
+ Coverage 91.81% 91.91% +0.09%
===========================================
Files 339 339
Lines 27009 27009
Branches 1954 1957 +3
===========================================
+ Hits 24799 24824 +25
+ Misses 2197 2172 -25
Partials 13 13 ☔ View full report in Codecov by Sentry. |
mrigankmg
reviewed
Jun 18, 2024
| new CommonTypesPlugin(), | ||
| ]); | ||
|
|
||
| expect(current?.validation).not.toBeUndefined(); |
There was a problem hiding this comment.
Do we need this if we are already testing for the validation object toHaveProperty("severity", "error"); on line 106?
There was a problem hiding this comment.
I think it just makes the test more easily identifiable if it fails, this will fail for the object not being defined, instead of saying it cant find a property
|
Should we also test for existence and functionality of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputtransformChange Type (required)
Indicate the type of change your pull request is:
patchminormajorDoes your PR have any documentation updates?