iOS: Add swiftlint as ios test #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bazel-6 #364 +/- ##
========================================
Coverage 91.70% 91.70%
========================================
Files 332 332
Lines 26714 26714
Branches 1935 1935
========================================
Hits 24499 24499
Misses 2202 2202
Partials 13 13 ☔ View full report in Codecov by Sentry. |
hborawski
reviewed
Jun 4, 2024
ios/BUILD.bazel
Outdated
| "//plugins/types-provider/ios:PlayerUITypesProviderPluginTests" | ||
| "//plugins/types-provider/ios:PlayerUITypesProviderPluginTests", | ||
|
|
||
| "@SwiftLint//:swiftlint" |
There was a problem hiding this comment.
do we need this? did it end up doing something useful?
tools/ios/util.bzl
Outdated
Comment on lines
60
to
87
|
|
||
| native.sh_test( | ||
| name = name + "SwiftLint", | ||
| srcs = [":"+ name + "_Lint"], | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| native.genrule( | ||
| name = name + "_Lint", | ||
| tools = [ | ||
| "@SwiftLint//:swiftlint" | ||
| ], | ||
| srcs = native.glob(["Sources/**/*.swift"]) + ["//:.swiftlint.yml"], | ||
| outs = ["output.sh"], | ||
| executable = True, | ||
| visibility = ["//visibility:public"], | ||
| cmd=""" | ||
| echo `$(location @SwiftLint//:swiftlint) --config $(location //:.swiftlint.yml) $(SRCS) || true` > lint_results.txt | ||
| LINT=$$(cat lint_results.txt) | ||
|
|
||
| echo '#!/bin/bash' > $(location output.sh) | ||
| echo "echo '$$LINT'" > $(location output.sh) | ||
|
|
||
| LINESWITHERROR=$$(echo grep error lint_results.txt || true) | ||
| echo "exit $$(($$LINESWITHERROR) | wc -l)" >> $(location output.sh) | ||
| """ | ||
| ) | ||
|
|
There was a problem hiding this comment.
can you move the lint definitions to the bottom of the macro?
The doc block has to be at the top of the function to meet the docstring format
tools/ios/util.bzl
Outdated
| tools = [ | ||
| "@SwiftLint//:swiftlint" | ||
| ], | ||
| srcs = native.glob(["Sources/**/*.swift"]) + ["//:.swiftlint.yml"], |
There was a problem hiding this comment.
if you move this further down the macro, you can use the same target to refer to sources that we use for the swift_library and for bundling the zip
Suggested change
| srcs = native.glob(["Sources/**/*.swift"]) + ["//:.swiftlint.yml"], | |
| srcs = [":" + name + "_Sources"] + ["//:.swiftlint.yml"], |
BUILD.bazel
Outdated
| @@ -248,3 +248,6 @@ gazelle( | |||
| name = "update_build_files", | |||
| gazelle = ":gazelle_bin", | |||
| ) | |||
|
|
|||
| #SwiftLint | |||
| exports_files([".swiftlint.yml", "output.sh"]) | |||
There was a problem hiding this comment.
Suggested change
| exports_files([".swiftlint.yml", "output.sh"]) | |
| exports_files([".swiftlint.yml"]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorDoes your PR have any documentation updates?