You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#216 Adds functionality to expose a read only instance of Player's Data Controller on the end state to allow Bindings to be evaluated after a flow has ended. This functionality should be exposed on JVM/Android
The text was updated successfully, but these errors were encountered:
// TODO: Completed state dataModel change needs rectification here
publicval dataModel:DataModelWithParser by lazy {
DataModelWithParser(controllers.data.node)
}
But not through the controllers API, and it doesn't include the safeguards against invoking the set APIs. We should:
Maintain API level parity with core (i.e. player.completedState?.controllers?.data)
Should create an extension for supporting player.completedState?.dataModel and mark as deprecated
Restrict the typing of this to only provide access to the getter APIs
Maintain API level parity with core
We'll likely need a local CompletedState.ControllerState that only exposes data (or anything else that's potentially added to CompletedState). Then we can use the existing NodeSerializableField pattern for exposing that publicly .
Should create an extension for supporting player.completedState?.dataModel and mark as deprecated
Restrict the typing of this to only provide access to the getter APIs
We'll likely need a new interface that only exposes the gets -- which could be used as a super type to the existing DataModelWithParser and DataController. Open to ideas.
#216 Adds functionality to expose a read only instance of Player's Data Controller on the end state to allow Bindings to be evaluated after a flow has ended. This functionality should be exposed on JVM/Android
The text was updated successfully, but these errors were encountered: