Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use peer deps for all player-* deps #49

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Use peer deps for all player-* deps #49

merged 1 commit into from
Sep 11, 2024

Conversation

adierkens
Copy link
Member

@adierkens adierkens commented Sep 11, 2024

Migrates all @player-* deps for each asset to a peer-dependency to avoid duplicate copies being pulled in.
Updates @player-ui deps to latest pre-release

Fixes: #48

Version

Published prerelease version: 0.4.0-next.0

Changelog

🚀 Enhancement

🐛 Bug Fix

Authors: 2

@adierkens adierkens added the bug Something isn't working label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.43%. Comparing base (4cfee0c) to head (870396e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   47.26%   48.43%   +1.17%     
==========================================
  Files          71       71              
  Lines        1794     1794              
  Branches       48       48              
==========================================
+ Hits          848      869      +21     
+ Misses        944      925      -19     
+ Partials        2        0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adierkens adierkens merged commit bb9986c into main Sep 11, 2024
9 checks passed
@adierkens adierkens deleted the peer-deps branch September 11, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Dependency on @player-ui library
2 participants