-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devtools/console first code structure #10
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed most of these changes look like simple formatting/structural changes — are these all manual changes, or are things done automatically by prettier?
Do we need to update the generator to handle these automatically? Or are they primarily personal stylistic changes?
The generator's goal was to help us avoid making this kind of formatting/structural changes ourselves (e.g., avoiding naming the files as .test.tsx or .ts facilitates the generation process)
These were manual changes of when I started working on the Console Asset (way before the generator was implemented). I was following the code and structure convention from the other assets, so this resembles more those assets structures. |
Change Type (required)
Standardizing scaffolding, code reorder and additions from first console view working branch.
patch
minor
major