-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instance viewport resize event not sent to the server #48
Comments
It's doing this for me on https://training.play-with-docker.com. If I either resize the browser window or move the bar in the middle, the event is sent correctly to the backend. Can you check if it works for you on that URL? |
@marcosnils I am sorry I did not try it on that URL before. It indeed does work on that URL. I am still quite new to javascript (and also docker) I only see https://github.com/play-with-docker/sdk/blob/master/src/index.ts#L242 but to me it looks like and incoming message. I will continue and compare https://training.play-with-docker.com/ops-s1-hello/ with my results |
No worries! Happy to help investigating what might be happening. Ping here if you're still having issues and can't make progress. |
Having an other look at it the web page on training.play-with-docker.com does have code to emit the changes
This code is not visible on the master branch. I did some digging and found that commit hmm the code there is already commented but at least I can say that the website is not running on the latetsed sdk |
ping |
It appears that the SDK is not sending "instance viewport resize" events to the back-end.
I initial filed this issue in the play-with-docker.github.io project butrepository is better suited. I hope a fix can be implemented.
play-with-docker/play-with-docker.github.io#225
(pwd)
![saved](https://user-images.githubusercontent.com/57112/125273276-0bfad500-e30d-11eb-9655-089e7a2dacc1.png)
(sdk)
![saved2](https://user-images.githubusercontent.com/57112/125273181-f2598d80-e30c-11eb-9586-a60af53e259a.png)
The text was updated successfully, but these errors were encountered: