Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebP and AVIF support #104

Closed
andypost opened this issue Jan 30, 2024 · 3 comments
Closed

Add WebP and AVIF support #104

andypost opened this issue Jan 30, 2024 · 3 comments

Comments

@andypost
Copy link

What in this template can be improved or added as a feature?

Drupal has support for WebP since 9.2 ref https://www.drupal.org/node/3171135

AVIF support for read is also enough for start

What exactly should be updated?

Template provides support for webp out of box

How important is this feature to you?

Nowadays Google require it

Additional context

AVIF support could be tricky https://www.drupal.org/project/drupal/issues/3202016

@andypost
Copy link
Author

andypost commented Jan 30, 2024

This line needs improvement

drupal10/.platform.app.yaml

Lines 117 to 118 in e548e28

# Allow access to common static files.
'\.(jpe?g|png|gif|svgz?|css|js|map|ico|bmp|eot|woff2?|otf|ttf)$':

- '\.(jpe?g|png|gif|svgz?|css|js|map|ico|bmp|eot|woff2?|otf|ttf)$': 
+ '\.(avif|webp|jpe?g|png|gif|svgz?|css|js|map|ico|bmp|eot|woff2?|otf|ttf)$': 

gilzow added a commit that referenced this issue Feb 1, 2024
adds webp and avif to allowed static files. Partially addresses #104
@Mupsi
Copy link
Contributor

Mupsi commented Feb 2, 2024

Hey @andypost! @gilzow fixed the line you highlighted; if there are additional changes required please let us know :) Thanks!

@andypost
Copy link
Author

andypost commented Feb 2, 2024

Thank you a lot 🙏

@andypost andypost closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants