Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the keyboard in onboarding screens #1752

Merged
merged 2 commits into from
Feb 1, 2025
Merged

fix the keyboard in onboarding screens #1752

merged 2 commits into from
Feb 1, 2025

Conversation

joshuatbrown
Copy link
Contributor

@joshuatbrown joshuatbrown commented Jan 31, 2025

Issues covered

https://github.com/verse-pbc/issues/issues/178

Description

A description of the changes proposed in the pull request. Explain what it does to give the reviewer some context for what they're reviewing.

How to test

  1. Navigate to...
  2. Tap...

Screenshots/Video

Post screenshots or video showing your changes, ideally showing how the app worked before and after these changes. Delete this section if this PR contains no visual changes.

Before After
replaceme replaceme

@mplorentz
Copy link
Member

Do you have some idea why this broke?

@bryanmontz
Copy link
Contributor

Do you have some idea why this broke?

It doesn't look like this is new. I reproduced it in the simulator at the v1.0.3-294 tag from December 4th.

Copy link
Contributor

@bryanmontz bryanmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I hope you don't mind that I added the CHANGELOG line to get it to pass the pipeline.

@bryanmontz bryanmontz added this pull request to the merge queue Feb 1, 2025
Merged via the queue into main with commit f1441e6 Feb 1, 2025
4 checks passed
@bryanmontz bryanmontz deleted the fix-keyboard branch February 1, 2025 14:34
@bryanmontz
Copy link
Contributor

These changes fixed the issue for me. Before them, I was able to reproduce the issue in a simulator, and after them I could not. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants