-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show follow notification in tab #1727
base: main
Are you sure you want to change the base?
Conversation
👀 |
Unfortunately, I'm getting some errors in my console that I think are the root cause of my old notifications not showing up. Here's what I see frequently in the console:
I know I dealt with this when I added the new AuthorList entity, and I assume the issue here is similar. I don't entirely remember what the solution was there, but I'd be happy to debug with you if you'd like. |
Thanks @joshuatbrown. I will love to debug with you today. |
To avoid over complicating things, after debugging with @joshuatbrown, we deem it best to fetch Events for inNetwork and outOfNetwork, then fetch NosNotifications for followEvents. We don't think performance wise, it is okay to convert 300 old notifications from Events to NosNotifications on app launch or when the user taps the notification tab button. Given this change, I think it is fine to revert to the previous database definition we had. Thoughts? cc: @mplorentz |
Reverting sounds fine to me, but I'd love to hear Matt's thoughts. |
Issues covered
127
P/S: This needs the backend to send follow notifications as a silent one and not an alert. This needs to be taken into consideration before merging.
Description
I wasn't expecting this PR to turn out this huge, but it did 😿. It contains the following changes:
NosNotification
entity needed a relationship with theEvent
entity.NosNotificationViewModel
andNotificationView
.NosNotification
and local notification for a silent follow notification.NosNotification
reference when anEvent
is deleted in theDatabaseCleaner
. Thanks for fixing this @mplorentz.How to test
Screenshots/Video
Post screenshots or video showing your changes, ideally showing how the app worked before and after these changes. Delete this section if this PR contains no visual changes.
Notification tab view
Video showing follows notification, inNetwork and outOfNetwork.
https://github.com/user-attachments/assets/a08cab0c-0a66-4099-9b8c-3b31b3bee6eb
N/B: I updated the UI after making the video. The screenshot above is the correct UI.