Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

아레나에서 동점일때 자기 자신이 동일 순위가 아니라 제일 상위 순위로 표시됨 #5469

Closed
sonohoshi opened this issue Jul 22, 2024 — with Slack · 3 comments · Fixed by #5495
Assignees
Labels
bug Something isn't working
Milestone

Comments

Copy link
Member

아레나에서 이번 시즌부터 동점일때 자신은 동점 제외한 순위로 나오던데 이러면 보상시 오해의 소지가 있을 것 같은데 괜찮은가요

Slack Message

@sonohoshi sonohoshi added the bug Something isn't working label Jul 22, 2024 — with Slack
@github-actions github-actions bot added this to the v210.0.0 milestone Jul 22, 2024
@tyrosine1153 tyrosine1153 moved this from Todo to In Progress in Nine Chronicles Jul 23, 2024
@tyrosine1153
Copy link
Contributor

@sonohoshi 혹시 아까 말씀하셨던 이 이슈의 원인이나 알고계신 부분에 대해서 설명해주실 수 있으신가요?

@sonohoshi
Copy link
Member Author

@tyrosine1153 https://github.com/planetarium/NineChronicles/blob/main/nekoyume/Assets/_Scripts/State/RxProps.Arena.cs#L350 여기 보시면 됩니다. 헤드리스가 정렬해서 주는 상태가 액션 렌더 직후에는 갱신되어있지 않을 수 있어서 클라에서 갱신을 한번 더 한건데, 이 경우 생기는 문제입니다.

@tyrosine1153
Copy link
Contributor

참고하겠습니다 감사합니다

@tyrosine1153 tyrosine1153 moved this from In Progress to Review in Nine Chronicles Jul 23, 2024
@tyrosine1153 tyrosine1153 linked a pull request Jul 24, 2024 that will close this issue
@tyrosine1153 tyrosine1153 moved this from Review to Merged in Nine Chronicles Jul 24, 2024
@github-project-automation github-project-automation bot moved this from Merged to Done in Nine Chronicles Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants