Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding file types #45

Open
gaul opened this issue Mar 13, 2021 · 1 comment · May be fixed by #56
Open

Excluding file types #45

gaul opened this issue Mar 13, 2021 · 1 comment · May be fixed by #56

Comments

@gaul
Copy link
Contributor

gaul commented Mar 13, 2021

I would like to exclude file types that are not interesting to network file systems, e.g., block and char. I could add an array with all types to misc.sh which the environment would override. This would require doing some math in all the test plans, e.g., echo "1..203" becomes something like echo "1..$((${#DEVICE_TYPES[@]} * 7))". Is there a better approach to this than doing a bunch of arithmetic? I see some existing feature detecting code like:

if supported lchmod; then
        echo "1..203"
else
        echo "1..119"
fi
@asomers-ax
Copy link

Calculating the plan would become very complicated with your proposal. This is one of the problems with TAP. I don't see a better option that doing arithmetic like you propose.

@twied twied linked a pull request Jan 30, 2022 that will close this issue
asomers pushed a commit to asomers/pjdfstest that referenced this issue Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants