-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
But I see the master branch is suffering from the exact same issue with the tests, so it probably doesn't have to do with the socket switch |
Travis failed because it doesn't update the dependencies from SPM |
@matthijs2704 thanks for this! Is the testing issue related to Travis or do you see failed tests on your own builds as well? All I see in Travis is errors like the following, which I don't quite understand (but seem to be related to files in a vapor dependency):
Perhaps we should change the Travis config to use the Swift Package manager build (i.e. I would also be in favor of removing the XCode project and all Info plists altogether - users of the library can simply |
I see the failed tests on both Travis and local, but not consistently. Maybe it has to do with the installed Swift version on Travis? I know for sure this works, as I am using this in my project. But I have yet to test on Linux. |
Hm, so are those actual errors in the Rethink-Swift tests or build-related errors? (Not currently near my Mac so can't check - will try tonight). Travis has XCode 8.3 with Swift 3.2 if I remember correctly, so this shouldn't really be an issue. I have seen intermittent failures in testing before by the way, those were related to threading issues in Rethink-Swift. Perhaps you should run the tests with ThreadSanitizer enabled to see what's going wrong. |
@matthijs2704 this tests and builds just fine on my Mac (Swift 3.1). Building with Xcode (9 beta) gives me an error related to an umbrella file, which is apparently located in "/Users/matthijs"... After generating a completely new Xcode project using So: please remove the Rethink.xcodeproj from your tree, edit the README to say people should use SPM or generate-xcodeproj, and we're good to merge! (En nogmaals dank voor je bijdrage!) |
Yep yep! Geen probleem ;) It should be ready to go now! |
Oh wait we need to fix the tests now, one sec |
Okay tests failed because a dependency from Vapor fails to compile for some reason. So we're good :) |
There we go! 🎉 |
We can also add linux tests now, I'll take a look at that in a sec. Travis can build both on osx and linux simultaneously, but need to lookup the syntax for that. (Can also be a separate PR) |
Current status is that the tests are running successfully on macOS, but are failing on Linux as it seems that there is no working communication (yet). But the good news is that the code is building on Linux now! |
@matthijs2704 how are things progressing? |
For some reason the tests are sometimes working and sometimes they aren't, but I can't figure out why. Please respond with any changes, so we can finally fix #5 😄