From 0861188a8145d07021e4d15d8b438136d2ec0960 Mon Sep 17 00:00:00 2001 From: Ryan Dens Date: Wed, 24 Jul 2024 12:59:17 -0400 Subject: [PATCH 1/3] :bookmark: tag new version --- README.md | 4 ++-- pom.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index db3b43b..b5b5c52 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ To deserialize a CodeTF file using these objects, simply deserialize with Jackso ## Gradle ```kotlin -implementation("io.codemodder:codetf-java:4.1.2") +implementation("io.codemodder:codetf-java:4.1.3") ``` ## Maven @@ -25,7 +25,7 @@ implementation("io.codemodder:codetf-java:4.1.2") io.codemodder codetf-java - 4.1.2 + 4.1.3 ``` diff --git a/pom.xml b/pom.xml index c5d26f9..f154c8e 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ io.codemodder codetf-java - 4.1.2 + 4.1.3 codetf-java From 24337ff9af55b2d08789d2fe20c4e514721d8823 Mon Sep 17 00:00:00 2001 From: Ryan Dens Date: Wed, 24 Jul 2024 13:00:26 -0400 Subject: [PATCH 2/3] :recycle: rename accessors to match java bean conventions --- src/main/java/io/codemodder/codetf/Failure.java | 4 ++-- src/test/java/io/codemodder/codetf/CodeTFResultTest.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/io/codemodder/codetf/Failure.java b/src/main/java/io/codemodder/codetf/Failure.java index 3d1f70d..ad4d7d1 100644 --- a/src/main/java/io/codemodder/codetf/Failure.java +++ b/src/main/java/io/codemodder/codetf/Failure.java @@ -15,11 +15,11 @@ public Failure( this.exception = exception; } - public String reason() { + public String getReason() { return reason; } - public String exception() { + public String getException() { return exception; } } diff --git a/src/test/java/io/codemodder/codetf/CodeTFResultTest.java b/src/test/java/io/codemodder/codetf/CodeTFResultTest.java index c987060..3a87a8f 100644 --- a/src/test/java/io/codemodder/codetf/CodeTFResultTest.java +++ b/src/test/java/io/codemodder/codetf/CodeTFResultTest.java @@ -161,7 +161,7 @@ void it_has_changeset_with_ai() { @Test void it_has_failure_state() { Failure state = new Failure("reason", "exception"); - assertEquals("reason", state.reason()); - assertEquals("exception", state.exception()); + assertEquals("reason", state.getReason()); + assertEquals("exception", state.getException()); } } From d13171c6a052be38f93bb7a6c115b03ef441af8e Mon Sep 17 00:00:00 2001 From: Ryan Dens Date: Wed, 24 Jul 2024 13:01:23 -0400 Subject: [PATCH 3/3] :bug: rename failure accessor to match java bean conventions --- src/main/java/io/codemodder/codetf/CodeTFResult.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/io/codemodder/codetf/CodeTFResult.java b/src/main/java/io/codemodder/codetf/CodeTFResult.java index 8809c2a..a32521d 100644 --- a/src/main/java/io/codemodder/codetf/CodeTFResult.java +++ b/src/main/java/io/codemodder/codetf/CodeTFResult.java @@ -1,6 +1,7 @@ package io.codemodder.codetf; import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonIgnore; import com.fasterxml.jackson.annotation.JsonProperty; import java.util.*; import java.util.stream.Collectors; @@ -68,7 +69,7 @@ public DetectionTool getDetectionTool() { return detectionTool; } - public Failure getFailureState() { + public Failure getFailure() { return failure; } @@ -100,6 +101,7 @@ public boolean usesAi() { return changeset.stream().anyMatch(CodeTFChangesetEntry::usesAi); } + @JsonIgnore public List getFixedFindings() { return changeset.stream() .map(CodeTFChangesetEntry::getChanges) @@ -189,7 +191,7 @@ public CodeTFResult build() { updatedSummary != null ? updatedSummary : originalResult.getSummary(), updatedDescription != null ? updatedDescription : originalResult.getDescription(), detectionTool != null ? detectionTool : originalResult.getDetectionTool(), - failure != null ? failure : originalResult.getFailureState(), + failure != null ? failure : originalResult.getFailure(), originalResult.getFailedFiles(), updatedReferences != null ? updatedReferences : originalResult.getReferences(), originalResult.getProperties(),