From 84678c250c1a92c46bef665c2af0da1ac09ee1bb Mon Sep 17 00:00:00 2001 From: Daniel D'Avella Date: Tue, 3 Dec 2024 16:59:49 -0500 Subject: [PATCH 1/3] Add fixedFindings field to ChangeSet --- codetf.schema.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/codetf.schema.json b/codetf.schema.json index c7dfc48..94a2551 100644 --- a/codetf.schema.json +++ b/codetf.schema.json @@ -180,6 +180,11 @@ "provisional": { "type": "boolean", "description": "Indicates that the fix is provisional" + }, + "fixedFindings": { + "type": "array", + "description": "List of findings that were fixed by this changeset", + "items": { "$ref": "#/definitions/detector/fixedFinding" } } }, "required": ["path", "diff", "changes"] From 134d90bb66b9163d01cd6945c111f7689da05f76 Mon Sep 17 00:00:00 2001 From: Daniel D'Avella Date: Tue, 3 Dec 2024 17:40:54 -0500 Subject: [PATCH 2/3] Change change.findings => fixedFindings --- codetf.schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codetf.schema.json b/codetf.schema.json index 94a2551..bc8bb9a 100644 --- a/codetf.schema.json +++ b/codetf.schema.json @@ -216,7 +216,7 @@ "description": "The package actions that were needed to support changes to the file", "items": { "$ref": "#/definitions/packageAction" } }, - "findings": { + "fixedFindings": { "type": "array", "description": "List of findings that were fixed at this location", "items": { "$ref": "#/definitions/detector/fixedFinding" } From e5177708fedd25cf02cd405c18854cc2eab96e94 Mon Sep 17 00:00:00 2001 From: Daniel D'Avella Date: Tue, 3 Dec 2024 20:49:44 -0500 Subject: [PATCH 3/3] Clarify description of changeset.fixedFindings --- codetf.schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codetf.schema.json b/codetf.schema.json index bc8bb9a..107bcab 100644 --- a/codetf.schema.json +++ b/codetf.schema.json @@ -183,7 +183,7 @@ }, "fixedFindings": { "type": "array", - "description": "List of findings that were fixed by this changeset", + "description": "List of findings that were fixed by this changeset. Used for findings that can't be attached to a specific change.", "items": { "$ref": "#/definitions/detector/fixedFinding" } } },