Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning messages for unsupported HASH_JOIN hints #58647

Open
Rustin170506 opened this issue Jan 2, 2025 · 0 comments · May be fixed by #58646
Open

Improve warning messages for unsupported HASH_JOIN hints #58647

Rustin170506 opened this issue Jan 2, 2025 · 0 comments · May be fixed by #58646
Labels
sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@Rustin170506
Copy link
Member

Enhancement

Some of the other warning messages for HASH_JOIN hints are very poor.

For example:

  1. p.SCtx().GetSessionVars().StmtCtx.SetHintWarning("Some HASH_JOIN_BUILD and HASH_JOIN_PROBE hints are conflicts, please check the hints")
  2. p.SCtx().GetSessionVars().StmtCtx.SetHintWarning(fmt.Sprintf("We can't use the HASH_JOIN_BUILD or HASH_JOIN_PROBE hint for %s, please check the hint", p.JoinType))
  3. p.SCtx().GetSessionVars().StmtCtx.SetHintWarning(fmt.Sprintf("We can't use the HASH_JOIN_BUILD or HASH_JOIN_PROBE hint for %s, please check the hint", p.JoinType))

The warnings are very confusing, we need to make the warnings clearer and more specific.

@Rustin170506 Rustin170506 added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant