Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CookieManager asserts value isNotEmpty, but the cookie value can be empty in real world #2484

Open
2 tasks done
laishere opened this issue Dec 30, 2024 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working

Comments

@laishere
Copy link

laishere commented Dec 30, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Not empty value cookie is not allowed.

Expected Behavior

Should allow empty cookie value.

Steps with code example to reproduce

Steps with code example to reproduce
// No code

Stacktrace/Logs

Stacktrace/Logs
<Replace this line by pasting your stacktrace or logs here>

Flutter version

v3.24.3

Operating System, Device-specific and/or Tool

Android API 30

Plugin version

v6.1.5

Additional information

Check the code here:

Self grab

  • I'm ready to work on this issue!
@laishere laishere added the bug Something isn't working label Dec 30, 2024
@laishere laishere changed the title CookieManager asserts value isNotEmpty, but the cookie value can be true in real world CookieManager asserts value isNotEmpty, but the cookie value can be empty in real world Dec 30, 2024
@laishere
Copy link
Author

Set-Cookie syntax in RFC 6265

set-cookie-header = "Set-Cookie:" SP set-cookie-string
set-cookie-string = cookie-pair *( ";" SP cookie-av )
cookie-pair = cookie-name "=" cookie-value
cookie-name = token
cookie-value = *cookie-octet / ( DQUOTE *cookie-octet DQUOTE )

Which indicates that an empty cookie-value is legal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant