Add instuctions for updating cloudflared binary.

[iUnknwn]

Adds a section to the DNS-Over-HTTPS guide with instructions for how to ensure the cloudflared daemon is kept up-to-date.

This adds update instructions for cloudflared, which handles one part of issue #175

[dschaper]

Thanks for the submission. I'm not a fan of automated updates without intervention so I'm not going to approve but the other team members may have different opinions.

[dschaper]

[iUnknwn]

The docs I added are simply calling that, actually (and then calling systemctl restart) - if you'd prefer, I can alter the docs to simply explain how to do an updating manually, and then just have a note you can automate it by placing it inside the weekly cron folder?

[dschaper]

Yeah, that sounds like a better way to document it. Have the manual process be the main topic and then add a note for how to automate. Bonus if you want to do cron and systemds timers!

[iUnknwn]

@dschaper Done - I've updated the docs so the manual method is described first, and then there's a note on how to do automatic updating via cron.

Also, I made a small comment earlier in the guide that cloudflared will also work with other DoH providers (so the same setup can be used for google DNS for example).

[dschaper]

@iUnknwn Can you rebase this on master? There have been some changes.

[netlify]

Deploy preview for pihole-docs ready!

Built with commit 3337b2a

https://deploy-preview-215--pihole-docs.netlify.app

[iUnknwn]

@dschaper Done - rebased onto master.

[dschaper]

Thanks, some linting comments, I'll check them over in a bit.

 docs/guides/dns-over-https.md:65:99 MD034/no-bare-urls Bare URL used [Context: "https://8.8.8.8/dns-query"]
docs/guides/dns-over-https.md:156:91 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
docs/guides/dns-over-https.md:156:91 MD047/single-trailing-newline Files should end with a single newline character

[XhmikosR]

I don't think this patch is correct. If one has installed cloudflared following the existent guide, then cloudflared won't run as root so updating it with its built-in command can mess things up.

I suggest that we focus on finishing #186 first and build on top of that.

[XhmikosR]

@iUnknwn can you fetch the latest master and check what still applies? I added some info in #186

[iUnknwn]

This overlaps with the majority of my PR - the only thing that still might be useful is the note about how cloudflared can be configured to use other DoH providers.

Do you want me to update this PR, or open a new one just for that specific improvement?

[XhmikosR]

I think you should try keeping most of your changes and we see the diff. There are some differences including the cron job (which I thought is not needed)

[iUnknwn]

@XhmikosR OK - all of those changes should be in this PR - do you want me to do a rebase onto the current docs, or just leave what I currently have?

[XhmikosR]

Just rebase this branch and add any more info and we'll review it.

[iUnknwn]

Done - just rebased on top of master.

[XhmikosR]

Suggested change

	**Note:** The `cloudflared` binary will work with other DoH providers (for example, you could use https://8.8.8.8/dns-query for Google DNS).
	**Note:** The `cloudflared` binary will work with other DoH providers (for example, you could use `https://8.8.8.8/dns-query` for Google DNS).

[XhmikosR]

Suggested change

	The system will now attempt to update the cloudflared binary automatically, once per week.
	The system will now attempt to update the cloudflared binary automatically, once per week.

[iUnknwn]

@XhmikosR done - changes made.

[iUnknwn]

...Actually, I'm re-reading this and I notice we now have two updating cloudflared sections, should the section section be renamed "Keeping Cloudflared Up-To-Date" or something like that?

[XhmikosR]

You need to merge your update changes with the current one.

[iUnknwn]

OK - changes merged.

That said, I'm wondering if there might be a way to simply this guide considerably. The main reason to keep the manual configuration route is to give people an option to avoid running cloudflared as root, correct?

If so, wouldn't it make more sense to simply write an extension unit file (as described here). That would let people configure the binary to run as its own non-root user, and it would prevent future updates from overwriting the change.

If we did this, we'd be able to remove all the sections that refer to manual configuration, and I think it would make the guide considerably more readable (we'd no longer need two sub sections for each install, update, and delete step).