-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use main branch from calibreapp/image-actions and run on schedule #1144
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: yubiuser <[email protected]>
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Some day there might be a new release: calibreapp/image-actions#283 |
Do we want to run this on all PRs or keep the current behaviour? docs/.github/workflows/calibreapp-image-actions.yml Lines 5 to 9 in 448e7b4
We might be able to re-compress existing images if the action changes their compression algortihm. |
Signed-off-by: yubiuser <[email protected]>
I added a commit following their example (https://github.com/calibreapp/image-actions?tab=readme-ov-file#combined-workflow) to run this on schedule and open a PR if needed. I only changed the action used to create the PR, omitting peter-evans and using |
TBH, this doesn't seem to even come close to the compression one can get with other scripts/tools. Unfortunately, I've yet to find an automated way for this, but I can submit a PR later which compresses the images as good as I can get them to compress. |
Sure, go ahead |
What does this PR aim to accomplish?:
Use main branch from calibreapp/image-actions as it contains updates compared to their latest, outdated tagged version
Ref:
https://github.com/calibreapp/image-actions?tab=readme-ov-file#-usage
https://github.com/calibreapp/image-actions/tags
By submitting this pull request, I confirm the following:
git rebase
)