-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress curl and floating number conversion #397
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Conflicts have been resolved. |
There are more errors that need to be addressed
Signed-off-by: yubiuser <[email protected]>
I pushed a commit that should guard all floating number conversions. Please test @rdwebdesign |
Tested after your new commit, but it still shows the same invalid number error. See my comments in MM. |
…ormation Signed-off-by: yubiuser <[email protected]>
Setting to draft, maybe most won't be needed when we reduce the number of API calls |
Superseded by #399 |
What does this PR aim to accomplish?:
During rare circumstances (FTL restart and PADD data request)
curl
could fail and output error text in the unusedx/y-offset
margins. As this area is not cleared by default (to avoid flickering) the error text remains.This PR removes the
-S, --show-error
flag fromcurl
calls to prevent any error output.Additionally, it guards floating number conversions incase the input is empty.
By submitting this pull request, I confirm the following:
git rebase
)