Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress curl and floating number conversion #397

Closed
wants to merge 4 commits into from

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jul 17, 2024

What does this PR aim to accomplish?:

During rare circumstances (FTL restart and PADD data request) curl could fail and output error text in the unused x/y-offset margins. As this area is not cleared by default (to avoid flickering) the error text remains.

This PR removes the -S, --show-error flag from curl calls to prevent any error output.

Additionally, it guards floating number conversions incase the input is empty.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved.

@yubiuser yubiuser requested a review from a team July 22, 2024 19:15
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

yubiuser added 2 commits July 24, 2024 13:37
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Copy link

Conflicts have been resolved.

DL6ER
DL6ER previously approved these changes Jul 26, 2024
@rdwebdesign
Copy link
Member

The issue is still happening.

image

@DL6ER DL6ER dismissed their stale review July 27, 2024 06:25

There are more errors that need to be addressed

@yubiuser
Copy link
Member Author

I pushed a commit that should guard all floating number conversions. Please test @rdwebdesign

@yubiuser yubiuser requested a review from rdwebdesign July 27, 2024 17:02
@yubiuser yubiuser changed the title Don't show curl errors Suppress curl and floating number conversion Jul 27, 2024
@rdwebdesign
Copy link
Member

Tested after your new commit, but it still shows the same invalid number error. See my comments in MM.

@yubiuser
Copy link
Member Author

yubiuser commented Aug 6, 2024

Setting to draft, maybe most won't be needed when we reduce the number of API calls

@yubiuser yubiuser marked this pull request as draft August 6, 2024 14:52
@yubiuser
Copy link
Member Author

yubiuser commented Aug 9, 2024

Superseded by #399

@yubiuser yubiuser closed this Aug 9, 2024
@yubiuser yubiuser deleted the silence/curl branch August 9, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants