Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADD v4.0.0 #373

Merged
merged 144 commits into from
Feb 24, 2025
Merged

PADD v4.0.0 #373

merged 144 commits into from
Feb 24, 2025

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Sep 25, 2023

yubiuser and others added 30 commits July 19, 2022 15:10
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
@XhmikosR
Copy link

XhmikosR commented Feb 18, 2025

@yubiuser I just tried this branch with v6 and so far it works but there's one annoying thing that it asks for the Web password each time. Am I missing something?

EDIT: NVM I just saw that it's required now, but I don't see it documented in README.md. Maybe it would be possible to provide the password another way instead of having to pass it each time as a flag?

@mwoolweaver
Copy link
Contributor

mwoolweaver commented Feb 18, 2025

@XhmikosR
Copy link

Same issue:

START UP ===================================================
                    Establishing connection with FTL...
                    No password supplied. Please enter your password:

I'm running padd.sh on the same Pi I run Pi-hole.

@mwoolweaver
Copy link
Contributor

is the user in the pihole group? if not then the password is needed

see #392

@XhmikosR
Copy link

Ah, that was it, thanks!

Could this be documented somewhere in the upgrade notes maybe?

@yubiuser
Copy link
Member Author

I can add a note to the PADD README

@mwoolweaver
Copy link
Contributor

also passing the password via --secret will likely not work until something like #415 or #416 get merged into the development branch as noted in #414

@yubiuser yubiuser marked this pull request as ready for review February 24, 2025 17:42
@yubiuser yubiuser requested a review from a team February 24, 2025 17:42
@yubiuser yubiuser merged commit 48291ad into master Feb 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants