Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push development branch to master #425

Open
robcmo opened this issue Feb 24, 2025 · 3 comments · May be fixed by #428
Open

push development branch to master #425

robcmo opened this issue Feb 24, 2025 · 3 comments · May be fixed by #428

Comments

@robcmo
Copy link

robcmo commented Feb 24, 2025

Now that Pi-Hole 6 is released, the release version of padd.sh does not work. Installing the dev branch does work, except the loss of temperature which was said to be deprecated so lines 416-417 need to be removed.

@mwoolweaver
Copy link
Contributor

mwoolweaver commented Feb 24, 2025

except the loss of temperature which was said to be deprecated so lines 416-417 need to be removed.

the Temp is still shown in PADD as seen here
Image

and as seen here pi-hole/web#3218 (comment)

Removal of the temp icon and value on the web interface is by design. It's still present in the API - we left it exclusively for PADD.

@robcmo
Copy link
Author

robcmo commented Feb 24, 2025

Removal of the temp icon and value on the web interface is by design. It's still present in the API - we left it exclusively for PADD.

@mwoolweaver, that's great news, but it no longer works for me. I will check the logs.

Image

@yubiuser
Copy link
Member

#428 will fix this

@yubiuser yubiuser linked a pull request Feb 24, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants