Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some settings do not apply until pihole-FTL.service is manually restarted #2287

Open
fongd opened this issue Feb 26, 2025 · 1 comment
Open

Comments

@fongd
Copy link

fongd commented Feb 26, 2025

Versions

  • Core version is v6.0.4 (Latest: v6.0.4)
  • Web version is v6.0.1 (Latest: v6.0.1)
  • FTL version is v6.0.2 (Latest: v6.0.2)

Platform

  • OS and version: Debian 12.9
  • Platform: VM in Proxmox 8.3

Expected behavior

When saving settings changes, all changes should take effect immediately upon save.

Actual behavior / bug

It appears that at least some settings require a manual restart of pihole-FTL.service.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to Settings > All settings
  2. Change the webserver.threads setting under the "Webserver and API" tab
  3. Click the "Save & Apply" button; Pi-hole tells you it is applying your changes
  4. The change to the number of threads has not actually been applied and will only be applied by manually restarting pihole-FTL.service

Debug Token

Screenshots

Image

This is misleading because Pi-hole hasn't actually applied all settings, at least not all web server settings.

Additional context

I'm not sure what gets applied immediately and what doesn't; webserver.threads is just one example that I found does not get automatically applied. I discovered this during troubleshooting #2284 (comment).

@DL6ER
Copy link
Member

DL6ER commented Feb 26, 2025

Thank you. My research showed it is really limited to webserver.threads and #2295 will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants