Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing V5 Teleporter DHCP config gets lease time wrong #2268

Open
clwgh opened this issue Feb 24, 2025 · 2 comments
Open

Importing V5 Teleporter DHCP config gets lease time wrong #2268

clwgh opened this issue Feb 24, 2025 · 2 comments

Comments

@clwgh
Copy link
Member

clwgh commented Feb 24, 2025

Versions

  • Core version is v6.0.4 (Latest: v6.0.4)
  • Web version is v6.0.1 (Latest: v6.0.1)
  • FTL version is v6.0.2 (Latest: v6.0.2)

Platform

  • OS and version: Pi OS Bookworm
  • Platform: RPi 3B+

Expected behavior

Fresh install of V6. Importing the Teleporter backup from the previous V5. This included V5's DHCP config. The DHCP lease time in my V5 was set to 168. This corresponded to hours and the web interface gave some examples, eg 168 is 1 week.

Actual behavior / bug

In V6, for the value to be treated as hours it turns out it must have the letter "h" appended. This does not happen with the import. Therefore the resulting DHCP lease time in my case was set to 168 seconds. This is reflected in the debug log.

Message type: DHCPOFFER (2)
server-identifier: 192.168.1.2
lease-time: 168 ( 2m 48s )
renewal-time: 84 ( 1m 24s )
rebinding-time: 147 ( 2m 27s )

Steps to reproduce

Import a V5 Teleporter backup, from a device which had DHCP enabled, into a fresh V6 setup. Observe that the value of the V5 lease time, in hours, is being treated as a value in seconds in V6.

Debug Token

https://tricorder.pi-hole.net/OmChMmGu/

Additional context

Side note - this template still references old names such as AdminLTE.

@yubiuser yubiuser transferred this issue from pi-hole/pi-hole Feb 24, 2025
@DL6ER
Copy link
Member

DL6ER commented Feb 24, 2025

Could you please try if

sudo pihole checkout ftl fix/teleporter_v5_leasetime

fixes this issue for you?

@DL6ER
Copy link
Member

DL6ER commented Feb 24, 2025

Fixed in development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants