Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing webhome causes FTL to hang/loop #2259

Open
Synetech opened this issue Feb 22, 2025 · 2 comments
Open

Changing webhome causes FTL to hang/loop #2259

Synetech opened this issue Feb 22, 2025 · 2 comments

Comments

@Synetech
Copy link

Versions

  • Pi-hole: 6.0.3
  • AdminLTE: 6.0.1
  • FTL: 6.0.2

Platform

Multiple

Expected behavior

Log in and use web-admin page like normal

Actual behavior / bug

Web-admin login page redirects then hangs in a loop, multiple pihole-FTL process peg CPU at 100%

Steps to reproduce

Steps to reproduce the behavior:

  1. Edit /etc/pihole/pihole.toml
  2. Change the webhome variable
  3. Move and/or rename /var/www/html/admin so that it matches webhome but is not the default
  4. See error

Additional context

I tested every permutation; it's the same result whether it's renamed (eg "/var/www/html/admim/"), it's moved (eg "/var/www/html/blah/admin/"), or both (eg "/var/www/html/foo/bar/").

I haven't tested if webroot is also changed, but it's safe to assume it's also likely broken because apparently, it's still looking for files in the default location:

2025-02-22 16:45:41.886 EST [5301/T5333] INFO: Local URI: "/adminp/"
2025-02-22 16:45:41.896 EST [5301/T5333] WARNING: Requested file "/var/www/html/admin/vendor/nprogress/nprogress.min.js" does not exist

@rdwebdesign
Copy link
Member

That's a known issue.

FTL has the ability to change webhome and some paths, but the original path is hard-coded in some places, including in Pi-hole core.

Thanks for reporting.

We will need to take a look in the hard-coded paths all over the code (all repos) before we can really fix this issue.

@DL6ER
Copy link
Member

DL6ER commented Feb 23, 2025

multiple pihole-FTL process peg CPU at 100%

On what kind of hardware? I was able to reproduce the (incorrect) looped reloading of the login page but it merely caused the page to be refreshed maybe 3 times per second. And FTL's CPU load does not spike notably on my small micro server (stays below 1%).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants